Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding versions to native extensions, updating extensions registry #881

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Adding versions to native extensions, updating extensions registry #881

merged 2 commits into from
Dec 6, 2023

Conversation

floydtree
Copy link
Contributor

Related Issue: #869

Description of changes:

  1. Adding native extension information to the extensions registry
  2. Adding versions to the natively defined extensions.

Followup:

  1. Add a metaschema check to ensure core version defined in /version.json remains in sync with extension versions. @alanisaac

@floydtree
adding native extension information to registry
cf3c6e6 
Signed-off-by: Rajas <rajaspa@amazon.com>
@floydtree
adding versions to all native extensions
e5d93fc 
Signed-off-by: Rajas <rajaspa@amazon.com>
@floydtree floydtree added enhancement New feature or request framework Structures, conventions, requirements, data types, etc. non_breaking Non Breaking, backwards compatible changes labels Dec 5, 2023
zschmerber
zschmerber approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@zschmerber zschmerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alanisaac
alanisaac approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@alanisaac alanisaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add a metaschema check to ensure core version defined in /version.json remains in sync with extension versions.

Can do! Hopefully soon the check will be in place so this can simply happen in line with PRs.

@floydtree floydtree merged commit 127a717 into ocsf:main Dec 6, 2023
2 checks passed
@floydtree floydtree deleted the extensions_fix branch December 6, 2023 14:52
@floydtree floydtree added the v1.1.0 Changes marked for v1.1.0 of OCSF label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanisaac alanisaac alanisaac approved these changes

@zschmerber zschmerber zschmerber approved these changes

@mikeradka mikeradka mikeradka approved these changes

@Aniak5 Aniak5 Awaiting requested review from Aniak5 Aniak5 is a code owner

@pagbabian-splunk pagbabian-splunk Awaiting requested review from pagbabian-splunk pagbabian-splunk is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request framework Structures, conventions, requirements, data types, etc. non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@floydtree @alanisaac @zschmerber @mikeradka