Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated the Web Resource Access Activity and enhanced Web Resources Activity #890

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

pagbabian-splunk
Copy link
Contributor

Related Issue:

Uses the new Security Control profile to add the access control semantics

Description of changes:

Deprecated the Web Resource Access Activity in favor of the Web Resources Activity class, using the Security Control and Network Proxy profiles to achieve the same semantics.

Enhanced the Web Resources Activity class to add the missing attributes from Web Resource Access Activity, including in the form of the Security Control and Network Proxy profiles.

… Resources Activity class, using the Security Control and Network Proxy profiles to achieve the same semantics.

Enhanced the Web Resources Activity class to add the missing attributes from Web Resource Access Activity, including in the form of the Security Control and Network Proxy profiles.

Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
@pagbabian-splunk pagbabian-splunk added enhancement New feature or request non_breaking Non Breaking, backwards compatible changes application_activity Issues related to Application Activity Category labels Dec 12, 2023
@pagbabian-splunk pagbabian-splunk added the deprecation A schema artifact is being deprecated label Dec 12, 2023
floydtree
floydtree previously approved these changes Dec 12, 2023
Copy link
Contributor

@floydtree floydtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Aniak5
Aniak5 previously approved these changes Dec 12, 2023
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

odianosen
odianosen previously approved these changes Dec 19, 2023
Copy link
Contributor

@odianosen odianosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@pagbabian-splunk pagbabian-splunk added the v1.1.0 Changes marked for v1.1.0 of OCSF label Dec 20, 2023
Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
@pagbabian-splunk pagbabian-splunk merged commit 8a728a0 into main Dec 20, 2023
2 checks passed
@floydtree floydtree deleted the web_activity branch January 4, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application_activity Issues related to Application Activity Category deprecation A schema artifact is being deprecated enhancement New feature or request non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants