Added the security_control profile, removed the malware attribute #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntained in security_control) and updated the class description to clarify how attacks should be duplicated. Signed-off-by: Paul Agbabian <pagbabian@splunk.com>
pagbabian-splunk
added
documentation
pagbabian-splunk
requested review from
floydtree,
zschmerber,
Aniak5 and
maxhotta
floydtree
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: 902
Description of changes:
Added the security_control profile to the class, removed the
malwareattribute with the rationale that it would only be reported when a security control product produced the Detection Finding.Updated the class description to apply the Security Control profile under those circumstances and to copy any MITRE Attack information from the
attacksattribute tofinding_infoso it can be made available in an Incident.This PR will supersede PR #894 which overrode, rather than removed the
malwareattribute from the class.