Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Findings category - description updates, addition of host profile #907

Merged
merged 5 commits into from
Jan 3, 2024
Merged

Findings category - description updates, addition of host profile #907

merged 5 commits into from
Jan 3, 2024

Conversation

floydtree
Copy link
Contributor

Related Issue: #902

Description of changes:

  1. Refining various descriptions (timestamps in the finding_info object)
  2. Adding host profile to allow utilization of device object for host details. Overriding device description.

@floydtree
updated descriptions for timestamp fields
261fd45 
Signed-off-by: Rajas <rajaspa@amazon.com>
@floydtree
Adding host profile to base finding class and overriding definition o…
cdad4dd 
…f device

Signed-off-by: Rajas <rajaspa@amazon.com>
@floydtree
Clarifying deprecation message
4f473c4 
Signed-off-by: Rajas <rajaspa@amazon.com>
@floydtree
Cleaning up redundant definition
0a5249d 
Signed-off-by: Rajas <rajaspa@amazon.com>
@floydtree floydtree added enhancement New feature or request findings Issues related to Findings Category non_breaking Non Breaking, backwards compatible changes description_updates Issues related to missing/incorrect/lacking descriptions of attributes v1.1.0 Changes marked for v1.1.0 of OCSF labels Jan 2, 2024
@floydtree
minor desc update
ad0e8ba 
Signed-off-by: Rajas <rajaspa@amazon.com>
@floydtree floydtree requested a review from Aniak5 January 3, 2024 14:45
@floydtree floydtree merged commit a49cfcd into ocsf:main Jan 3, 2024
2 checks passed
@floydtree floydtree deleted the findings_host branch January 3, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zschmerber zschmerber zschmerber approved these changes

@pagbabian-splunk pagbabian-splunk pagbabian-splunk approved these changes

@mikeradka mikeradka mikeradka approved these changes

@Aniak5 Aniak5 Awaiting requested review from Aniak5 Aniak5 is a code owner

Assignees
No one assigned
Labels
description_updates Issues related to missing/incorrect/lacking descriptions of attributes enhancement New feature or request findings Issues related to Findings Category non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@floydtree @zschmerber @pagbabian-splunk @mikeradka