Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 'Network File Activity' to 'Application -> File Hosting Activity' #917

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

mikeradka
Copy link
Contributor

Related Issue: #905

Description of changes:

This PR Deprecates the Network -> Network File Activity class and replaces it with the Application -> File Hosting Activity class. Tested and validated with our Box and OneDrive mappings.

image image image

Signed-off-by: Michael Radka <mradka@splunk.com>
…twork File Activity class

Signed-off-by: Michael Radka <mradka@splunk.com>
@mikeradka mikeradka self-assigned this Jan 5, 2024
@mikeradka mikeradka added network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes application_activity Issues related to Application Activity Category deprecation A schema artifact is being deprecated v1.1.0 Changes marked for v1.1.0 of OCSF labels Jan 5, 2024
Signed-off-by: Michael Radka <mradka@splunk.com>
@mikeradka mikeradka changed the title 905 Move 'Network File Activity' to 'Application -> File Hosting Activity' Jan 5, 2024
Copy link
Contributor

@adplotzk adplotzk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the changes are in line with what was discussed on the network call. Looks good.

Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Aniak5 Aniak5 merged commit 6d1d2cb into ocsf:main Jan 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application_activity Issues related to Application Activity Category deprecation A schema artifact is being deprecated network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants