Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completing kb_articles deprecation #924

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

floydtree
Copy link
Contributor

Related Issue: #855 ; #862

Description of changes:

  1. Deprecating kb_articles in favor of the newly created kb_article_list
  2. Removing stale references, replacing it with the newer attribute

Signed-off-by: Rajas <rajaspa@amazon.com>
Signed-off-by: Rajas <rajaspa@amazon.com>
Signed-off-by: Rajas <rajaspa@amazon.com>
@floydtree floydtree added non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF labels Jan 9, 2024
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@floydtree floydtree merged commit 568222d into ocsf:main Jan 9, 2024
2 checks passed
@floydtree floydtree deleted the kb_artice_deprecation branch January 9, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants