Create agent Object, add agent and owner to endpoint
#987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlmitch
reviewed
Mar 18, 2024
jonrau-at-queryai
requested review from
floydtree,
pagbabian-splunk,
Aniak5,
mikeradka and
zschmerber
as code owners
floydtree
requested changes
Mar 19, 2024
jonrau-at-queryai
changed the title
agent Object, add agent and owner to deviceagent Object, add agent and owner to endpoint
floydtree
previously approved these changes
Mar 19, 2024
jonrau-at-queryai
dismissed stale reviews from mikeradka and floydtree
via
dcdba03
|
Please check the description of |
floydtree
requested review from
mlmitch,
floydtree,
pagbabian-splunk and
mikeradka
mlmitch
reviewed
Mar 20, 2024
zschmerber
previously approved these changes
Mar 24, 2024
mikeradka
previously approved these changes
Mar 25, 2024
|
@jonrau-at-queryai Looks good to me, just approved, but there is a small merge conflict with the CHANGELOG. Could you update that so we can merge? |
Signed-off-by: Jonathan Rau <139361268+jonrau-at-queryai@users.noreply.github.com>
jonrau-at-queryai
dismissed stale reviews from mikeradka, zschmerber, and floydtree
via
8caad44
Looks like it's fixed, but it bumped all of the approvals again. |
mikeradka
previously approved these changes
Mar 25, 2024
floydtree
previously approved these changes
Mar 26, 2024
This was referenced Mar 26, 2024
Aniak5
reviewed
Mar 28, 2024
Signed-off-by: Jonathan Rau <139361268+jonrau-at-queryai@users.noreply.github.com>
jonrau-at-queryai
dismissed stale reviews from mikeradka and floydtree
via
f902fef
|
Looks great! Thanks for this addition, its super useful! |
mikeradka
approved these changes
Mar 28, 2024
floydtree
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
#986
Description of changes:
ownertodevice,endpoint, andnetwork_endpoint.agentobject that defines various sensors and agent.agentobject todevice,resource, andendpoint.is_appliedBoolean topolicy.