[BUG] Checking for constant overflow only work in whole program compilation #1051
Labels
Comments
|
cc @xclerc |
|
Tentative fix in #1052. |
hhugo
pushed a commit
that referenced
this issue
Sep 9, 2020
* Reproduction case. * Ensure the overflow warning is always displayed. * Synchronize "tools/travis.sh" with ".ocamlformat". * Dot no use the `Int` module, for the sake of backward compatibility. * Apply ocamlformat. * `Nativeint.equal` was not defined in OCaml 4.02. * Typo.
hhugo
added a commit
to hhugo/opam-repository
that referenced
this issue
Sep 29, 2020
…ml-ppx, js_of_ocaml-lwt, js_of_ocaml-toplevel, js_of_ocaml-tyxml, js_of_ocaml and js_of_ocaml-ppx_deriving_json (3.7.1)
CHANGES:
## Features/Changes
* lib: Add Navigator.{vendor,maxTouchPoints} (ocsigen/js_of_ocaml#1062)
* lib: adds the intersection observer API (ocsigen/js_of_ocaml#1063)
## Bug fixes
* compiler: revert of "Eliminate allocation of dummy function ocsigen/js_of_ocaml#1013"
* compiler: fix for ocsigen/js_of_ocaml#1051 (ocsigen/js_of_ocaml#1052), Ensure the overflow warning is always displayed
* runtime: add missing primitives for 4.11
* lib: Fix resize-observer (ocsigen/js_of_ocaml#1058)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
generate the following warning in whole program compilation
The same warning should trigger with separate compilation.
As an extension, we could imagine only warning if the problematic constant ends up being used in the generate javascript and give a chance to the deadcode elimination to do its job
The text was updated successfully, but these errors were encountered: