Compiler: demonstrate and fix bug from 1354 #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works much better than I would have thought. With the right intuition (this is just argument passing), the changes to the optimization phases are straightforward. The complexity is localized in |
This is cleaner since, when we have an 'Assign (x, y)', x is in scope.
|
Thanks for the fix. I've squashed some commit. Do you have more on this PR ? Can we merge ? |
hhugo
changed the title
I think we can merge |
hhugo
pushed a commit
to hhugo/opam-repository
that referenced
this pull request
Dec 19, 2022
…s_of_ocaml-ppx_deriving_json, js_of_ocaml-ppx, js_of_ocaml-lwt and js_of_ocaml-compiler (5.0.0) CHANGES: ## Features/Changes * Compiler: add support for effect handlers (--enable=effects) * Compiler: small refactoring in code generation * Compiler: check build info compatibility when linking js file. * Misc: fix and update benchmarks * Misc: upgrade CI * Toplevel: recover more names when generating code during toplevel evaluation * Runtime: wrapping exception or not is now controled in the runtime. ## Bug fixes * Runime: Gc.finalise_last should not be eliminated * Tyxml: reactive dom needed a fix after ocsigen/js_of_ocaml#1268 (ocsigen/js_of_ocaml#1353) * Toplevel: Make sure the toplevel uses the correct memory representaion for strings * Compiler: fix minifier, missing constraint on try-catch blocks. * Compiler: Miscompilation of code involving references and exceptions (ocsigen/js_of_ocaml#1354, ocsigen/js_of_ocaml#1356)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continues/replaces #1355
fix #1354