The async keyword should not be followed by a newline

[vouillon]

Fixes #1514

[xvw]

Hi @vouillon
I have try your fix on https://github.com/funkywork/yourbones/tree/main/examples and I still have an issue related to that kind of line:

this.connection.open(a),a=this.connection),this.connection=this.setConnection(a),await

in https://gist.github.com/xvw/767a6e2ad72bff091b594a542d3cc744
So I guess that the fix should be applied to await too.

[vouillon]

@xvw I missed a case. An async at the end of the line is not recognized as a keyword, and thus we get an error at the following await.

[hhugo]

@vouillon, I've added some tests and added more fixes. I also rebased your branch.

[xvw]

When I try locally I have the following issue

16:58:26.439 Uncaught SyntaxError: missing ) in parenthetical main.bc.js:4875

# Line
this.connection.open(a),a=this.connection),this.connection=this.setConnection(a),await

Using a pretty-printer, I have this line

open(a = this.connection) {
                        // After this comment
                        this.connection === a && this.connection.connected || (this.connection.connected && this.close(), "string" == typeof a && (await this.connection.open(a), a = this.connection), this.connection = this.setConnection(a), await this.connection.open(), this.registerEventListeners(), this.events.emit("connect"))
                        // Before this comment
                    }

https://gist.githubusercontent.com/xvw/7ea94ae5657df668f948b2f024b52ba1/raw/a1f58b468efdf27306d4539c1dd1fb27c09e27ed/stubs.js (line 18651)

[hhugo]

Trying your example from above, I see

ReferenceError: Cannot access 'b' before initialization
    at e (main.bc.js:411:7)
    at d (main.bc.js:2638:21)
    at d.next (<anonymous>)
    at main.bc.js:2646:56
    at new Promise (<anonymous>)
    at au (main.bc.js:2638:165)
    at window.DAppClient.<anonymous> (main.bc.js:2690:9)
    at Generator.next (<anonymous>)
    at j (main.bc.js:2661:14)
Promise.catch (async)
(anonymous) @ main.bc.js:2682
(anonymous) @ main.bc.js:2667
b9 @ main.bc.js:2660
initSDK @ main.bc.js:2680
ae @ main.bc.js:2676
Se @ main.bc.js:2807
window.DAppClient @ main.bc.js:6060
(anonymous) @ main.bc.js:11750
(anonymous) @ main.bc.js:11760

[xvw]

Trying your example from above, I see

ReferenceError: Cannot access 'b' before initialization
    at e (main.bc.js:411:7)
    at d (main.bc.js:2638:21)
    at d.next (<anonymous>)
    at main.bc.js:2646:56
    at new Promise (<anonymous>)
    at au (main.bc.js:2638:165)
    at window.DAppClient.<anonymous> (main.bc.js:2690:9)
    at Generator.next (<anonymous>)
    at j (main.bc.js:2661:14)
Promise.catch (async)
(anonymous) @ main.bc.js:2682
(anonymous) @ main.bc.js:2667
b9 @ main.bc.js:2660
initSDK @ main.bc.js:2680
ae @ main.bc.js:2676
Se @ main.bc.js:2807
window.DAppClient @ main.bc.js:6060
(anonymous) @ main.bc.js:11750
(anonymous) @ main.bc.js:11760

From yourbones/examples ?
You need to build the stubs before compilation using make js_stubs.

[hhugo]

I now just see

main.bc.js:11614 Request_permissions_rejection

Just checking: have you pinned js_of_ocaml-compiler ? what commit do you use ?

[hhugo]

I see a different line for line number 4875

window&&void

[xvw]

You need to run the application through a webserver (ie: python3 -m http.server --directory . ).
Yes I have opam update + opam upgrade

js_of_ocaml             5.3.0        Compiler from OCaml bytecode to JavaScript
js_of_ocaml-compiler    5.3.0        pinned to version 5.3.0 at git+https://github.com/ocsigen/js_of_ocaml.git#async-fix
js_of_ocaml-lwt         5.3.0        Compiler from OCaml bytecode to JavaScript
js_of_ocaml-ppx         5.3.0        Compiler from OCaml bytecode to JavaScript

[xvw]

Ok, using a fixed commit (9302343) it is working! Thanks a lot!