Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 'ellipse' method to canvasRenderingContext2D #1555

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

FayCarsons
Copy link
Contributor

@FayCarsons FayCarsons commented Jan 16, 2024

fix #1552

@hhugo
Copy link
Member

hhugo commented Jan 18, 2024

Thanks, I've added two commits to make the CI happy, I'll merge after it runs.

(I've noticed that ellipse was used in the examples/hyperbolic/hypertree.ml example and implemented as

let ellipse_arc c cx cy rx ry start fin clock_wise =
  c##save;
  c##translate (Js.float cx) (Js.float cy);
  c##scale (Js.float rx) (Js.float ry);
  c##arc
    (Js.float 0.)
    (Js.float 0.)
    (Js.float 1.)
    (Js.float start)
    (Js.float fin)
    clock_wise;
  c##restore

One could cleanup this example now that we have ellipse binding.

@hhugo hhugo merged commit 679bb51 into ocsigen:master Jan 18, 2024
15 checks passed
hhugo pushed a commit to hhugo/opam-repository that referenced this pull request Feb 21, 2024
CHANGES:

## Features/Changes
* Mics: fix support for OCaml 5.2
* Compiler: no longer rely on IIFE for scoping variable inside loops
* Compiler: avoid parsing bytecode sections twice, jsoo counter part of ocaml#12599
* Lib: add ellipse to canvasRenderingContext2D (@FayCarsons, ocsigen/js_of_ocaml#1555)

## Bug fixes
* Compiler: fix global dead code elimination in a toplevel context
* Compiler: fix exit-loop-early optim in presence of closure (ocsigen/js_of_ocaml#1561)
* Compiler: remove quadratic behavior in generate.ml (ocsigen/js_of_ocaml#1531, ocsigen/js_of_ocaml#1567)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Ellipse method for canvas API
2 participants