Runtime: reduce memory leak caused by channels #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
This was my first version too 😇 I'm looking back in review history and I think we ended up with #1577 because it separates the code we want to keep (with references being traced by the GC and nothing really depends on closing fds) from the code we eventually don't (overrides that can't be traced for ppx_expect compatibility). But that depends on a possibly faulty model for how you'd like this code to develop. If you'd rather go with #1581 and/or with moving overrides to the fd, then I think that's all a very reasonable way forward. |
|
Merging this one first, giving more time to properly fix the leak. |
|
Thanks @hhugo! |
mseri
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Mar 5, 2024
CHANGES: ## Features/Changes * Compiler: only flush the necessary env for closures (ocsigen/js_of_ocaml#1568) * Library: dialog element support ## Bug fixes * Compiler: fix --enable=vardecl * Compiler: fix parallel renaming (bug introduced in ocsigen/js_of_ocaml#1567) * Lib: fix paragraph construction and coercion * Runtime: reduce memory leak with channels (ocsigen/js_of_ocaml#1581)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.