Better stub generation #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
|
I would have expected to see a rule for |
|
Do you mean |
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
probably :) |
|
I've pushed a commit to use the ocaml lexer instead of a custom one. I should resolve some issue I had in #671 where |
|
Makes sense. That's quite a bit better. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is twofold:
Use dune's promotion mechanism to generate the stubs file. This makes it easier to verify that the process is correct as the generated stubs are now expected. This also makes it unnecessary for users to run any shell scripts during compilation.
The second commit replaces the shell script with a pure OCaml script. It's a little longer, but it should be portable. Also, it outputs the stubs with slightly better formatting.