Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unsigned int to caml_parse_sign_and_base #791

Closed
wants to merge 1 commit into from
Closed

Add unsigned int to caml_parse_sign_and_base #791

wants to merge 1 commit into from

Conversation

goodmind
Copy link
Contributor

@goodmind goodmind commented May 4, 2019

Fixes #790

@goodmind
Copy link
Contributor Author

goodmind commented May 4, 2019

@hhugo

@hhugo
Copy link
Member

hhugo commented May 4, 2019

merged in #793

@hhugo hhugo closed this May 4, 2019
@hhugo
Copy link
Member

hhugo commented May 4, 2019

(Note, I've cherry-picked your commit)

@hhugo
Copy link
Member

hhugo commented May 4, 2019

Thanks

@goodmind goodmind mentioned this pull request May 6, 2019
Closed
hhugo
hhugo reviewed Apr 12, 2020
View reviewed changes
runtime/stdlib.js
@@ -447,6 +447,7 @@ function caml_parse_sign_and_base (s) {
case 120: case 88: base = 16; i += 2; break;
case 111: case 79: base = 8; i += 2; break;
case 98: case 66: base = 2; i += 2; break;
case 117: case 85: sign = 0; i += 2; break;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sign = 0 was not correct here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhugo hhugo hhugo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scanf.sscanf failing with %u formatter
2 participants
@goodmind @hhugo