Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for custom events #877

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Added support for custom events #877

merged 1 commit into from
Oct 7, 2019

Conversation

monstasat
Copy link
Contributor

Added support for custom events

  • Added customEvent object type
  • Added Dom.createCustomEvent and Dom_html.createCustomEvent helper functions to allow creation of custom events
  • Added eventTarget##dispatchEvent method to allow dispatching of custom (and other) events

@hhugo
Copy link
Member

hhugo commented Sep 27, 2019

Can you try to rebase, that should fix the CI

@hhugo hhugo requested a review from TyOverby September 27, 2019 01:39
@monstasat
Copy link
Contributor Author

Rebased onto master branch.

@TyOverby
Copy link
Collaborator

From the mdn page there appear to be many more properties than are present in the PR. Why are these left out?

@monstasat
Copy link
Contributor Author

monstasat commented Sep 27, 2019 •
edited

As you can see on the page you've mentioned, all properties excluding detail are inherited from the parent object, Event:

This interface inherits properties from its parent, Event:

Event.bubbles Read only
A Boolean indicating whether the event bubbles up through the DOM or not.

Event.cancelBubble
A historical alias to Event.stopPropagation(). Setting its value to true before returning from an event handler prevents propagation of the event.

and so on...

js_of_ocaml bindings of Event object indeed lack properties according to the docs, but if you want them to be added, I think they should be added to the Event, not to the customEvent.

Here is the MDN page describing the Event object.

@TyOverby TyOverby merged commit 6f5b298 into ocsigen:master Oct 7, 2019
@hhugo hhugo mentioned this pull request Nov 10, 2019
Merged
hhugo added a commit to hhugo/opam-repository that referenced this pull request Nov 10, 2019
@hhugo
[new release] js_of_ocaml, js_of_ocaml-ocamlbuild, js_of_ocaml-ppx_de…
5fdf95c 
…riving_json, js_of_ocaml-tyxml, js_of_ocaml-ppx, js_of_ocaml-lwt, js_of_ocaml-compiler and js_of_ocaml-toplevel (3.5.0)

CHANGES:

## Features/Changes
* Compiler: Improve testing of the compiler (Ty Overby)
* Compiler: Add several macros for making the runtime easier to maintain (ocsigen/js_of_ocaml#771) (Ty Overby)
* Compiler: Allow to emit one javascript per compilation unit (ocsigen/js_of_ocaml#783)
* Compiler: refactoring (ocsigen/js_of_ocaml#781, ocsigen/js_of_ocaml#782, ocsigen/js_of_ocaml#787, ocsigen/js_of_ocaml#795, ocsigen/js_of_ocaml#802)
* Compiler: more source map location for the javascript runtime (ocsigen/js_of_ocaml#795)
* Compiler: tune variable naming (ocsigen/js_of_ocaml#838)
* Compiler: Work around num lib incompatibility
* Compiler: escape '</' in strings (ocsigen/js_of_ocaml#899)
* Compiler: speedup toplevel creation
* Runtime: support sharing when marshaling (ocsigen/js_of_ocaml#814)
* Runtime: add caml_obj_with_tag
* Runtime: support marshaling custom block
* Runtime: complete rewrite of bigarray
* Runtime: complete num implementation
* Runtime: add caml_ba_hash
* Runtime: rewrite polymorphic compare
* Ppx: switch ppx rewriter to the OCaml 4.08 ast
* Misc: Improve CI speed
* Misc: remove ppx_deriving dependency
* Misc: remove cppo dependency
* Misc: remove ppx_tools_versioned dependency in ppx_deriving_json
* Misc: support for ocaml 4.09
* Misc: switch to ocamlformat.0.12
* Misc: many more tests
* Misc: new jsoo_fs tool to embed files in a jsoo pseudo fs.
* Lib: Use expect tests
* Lib: Add support for 'addEventListener' with options (ocsigen/js_of_ocaml#807)
* Lib: Change api of [Lwt_js_events.async] (ocsigen/js_of_ocaml#862)
* Lib: Change api of responseText in xmlhttprequest (ocsigen/js_of_ocaml#863)
* Lib: add resizeObserver bindings
* Lib: Added support for custom events (ocsigen/js_of_ocaml#877)
* Lib: Added support for focus events (ocsigen/js_of_ocaml#885)
* Lib: Added `passive` option support for `Lwt_js_events` module
* Lib: Added bindings for pointer events (ocsigen/js_of_ocaml#894)

## Bug fixes
* Compiler: don't generate source if no-source-map passed (ocsigen/js_of_ocaml#780)
* Compiler: Fix compilation of [Array.set] to return [unit]/0 (ocsigen/js_of_ocaml#792)
* Compiler: Fix assertion failure (ocsigen/js_of_ocaml#828)
* Compiler: Fix compilation of exception handlers (ocsigen/js_of_ocaml#830)
* Compiler: Fix static evaluation of caml_equal (ocsigen/js_of_ocaml#906)
* Misc: Fix install on windows (ocsigen/js_of_ocaml#794)
* Lib: Fix Dom_svg.createForeignObject (ocsigen/js_of_ocaml#756)
* Runtime: Fix caml_obj_tag, causing miscompilation with lazy value (ocsigen/js_of_ocaml#772)
* Runtime: Fix caml_ml_seek_out, caml_ml_pos_out (ocsigen/js_of_ocaml#779) (Shachar Itzhaky)
* Runtime: caml_parse_sign_and_base to support unsigned syntax (ocsigen/js_of_ocaml#792) (Shachar Itzhaky)
* Runtime: fix encoding when printing to stdout (ocsigen/js_of_ocaml#800)
* Runtime: Handle browserfs in fs_node detection logic (ocsigen/js_of_ocaml#831)
* Runtime: fix Obj.tag (ocsigen/js_of_ocaml#832)
* Runtime: fix marshalling of custom blocks (ocsigen/js_of_ocaml#861)
* Runtime: fix frexp
* Runtime: fix float printing with "%f" and large floats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TyOverby TyOverby TyOverby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@monstasat @hhugo @TyOverby