Runtime: change representation of int64 #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the motivation behind the change? Speed? Correctness? |
|
Uniformity, I'd like to treat int64 as any other custom block. I'm not sure what's the impact on performance. |
hhugo
force-pushed
the
int64
branch
3 times, most recently
from
02e5b74
to
4316341
Compare
|
|
|
@vouillon, I've updated the PR to restore compatibility with |
|
@vouillon, any objections for merging this ? |
|
No objection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we can merge this PR,
we need to release 3.5.0 first
update packages that depend on the current representation
zarith_js_stubs
update base