Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove console.log in caml_sys_system_command #979

Merged
merged 6 commits into from
Apr 9, 2020
Merged

Remove console.log in caml_sys_system_command #979

merged 6 commits into from
Apr 9, 2020

Conversation

smondet
Copy link
Contributor

@smondet smondet commented Apr 4, 2020

No description provided.

@smondet
Copy link
Contributor Author

smondet commented Apr 7, 2020

Added a second commit because execSync actually seems to by default grab stdout and return it as a string:
https://stackoverflow.com/questions/30134236/use-child-process-execsync-but-keep-output-in-console

@hhugo
Copy link
Member

hhugo commented Apr 7, 2020

Thanks.

Can you add an entry to the changelog ?

Having a small reg-test for this would be nice (look at compiler/tests-jsoo/, after rebasing)

@hhugo
Copy link
Member

hhugo commented Apr 9, 2020

Looks good. I'll merge once travis is green.

@hhugo hhugo merged commit 8421c8c into ocsigen:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smondet @hhugo