Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: quieten the Lwt configure pass #717

Closed
avsm opened this issue Sep 23, 2019 · 1 comment
Closed

build: quieten the Lwt configure pass #717

avsm opened this issue Sep 23, 2019 · 1 comment
Milestone

Comments

@avsm
Copy link
Collaborator

avsm commented Sep 23, 2019

When embedding Lwt in larger dune workspaces, the configure script output is one of the few pieces of information emitted to stdout. The convention in dune is to only output warnings to the standard output/error, and to document the target which can be manually read in order to debug/check.

In Lwt's case, we could quieten this output:

    discover duniverse/lwt/src/unix/lwt_features.{h,ml},duniverse/lwt/src/unix/unix_c_flags.sexp,duniverse/lwt/src/unix/unix_c_library_flags.sexp
libev ................................... skipped
pthread ............................... available
eventfd ............................... available
fd passing ............................ available
sched_getcpu .......................... available
affinity getting/setting .............. available
credentials getting (Linux) ........... available
credentials getting (NetBSD) ........ unavailable
credentials getting (OpenBSD) ....... unavailable
credentials getting (FreeBSD) ....... unavailable
getpeereid .......................... unavailable
fdatasync ............................. available
netdb_reentrant ..................... unavailable
reentrant gethost* .................... available
st_mtim.tv_nsec ....................... available
st_mtimespec.tv_nsec ................ unavailable
st_mtimensec ........................ unavailable
BSD mincore ......................... unavailable

and document in the README the _build/<config file> which can be read to get the same information.

@aantron aantron added this to the 4.3.1 milestone Sep 23, 2019
@aantron
Copy link
Collaborator

aantron commented Sep 23, 2019

I silenced the configure script unconditionally for now. The printing code is still there, but it depends on a flag. I haven't exposed this flag in any way (such as through an environment variable), because I doubt anyone uses this output. If that's wrong, we can easily expose it on request.

The emitted config files are not so useful at the moment. I think the current configure script only emits code into them when it discovers something different from the default, so it can be hard to get a full picture of everything that was checked, and the outcome of each check. We can fix that on request also, and then I would put instructions into the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants