Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to Keyboard Functions #29

Merged
merged 3 commits into from
May 27, 2015
Merged

Conversation

spatializes
Copy link
Contributor

This PR makes a few enhancements to keyboard functionality.

  • Exposes the KeyToggle function for use in Robotjs.
  • Adds modifiers for KeyTap and KeyToggle.
  • Adds the ability to write single characters to KeyTap and KeyToggle.
  • Adds keys that were missing from KeyTap to both KeyTap and KeyToggle.
  • Fixes a bug I noticed in KeyTap. Seems it was not releasing the key. I used the OSX keyboard viewer to see this. As already suggested in one of the issues, I added a sleep function to fix. I did not fix this in the mouse events, but the mssleep function can be reused.

Closes #7
Closes #14

@octalmage
Copy link
Owner

Looks great, thanks a ton!! Let me test the changes then I'll merge it.

👍

@spatializes
Copy link
Contributor Author

Awesome, no problem. Let me know if you want anything refactored or done differently. I plan to use and extend quite a bit of this library for controlling PCs with a data glove I'm working on.

@octalmage
Copy link
Owner

Wow sounds epic! Can't wait to see the project.

@octalmage
Copy link
Owner

@drquinn this is small, but could you add periods to the end of all errors? Thanks!

@maxogden does this PR line up with your projects needs?

@max-mapper
Copy link

Sorry it's hard to tell from the diff (I am not very good at objective-c and don't have time to test out this branch at the moment), but my branch is here for reference https://github.com/maxogden/robotjs/commits/keyupdown

@octalmage
Copy link
Owner

No worries! I'll check it out. I just want to avoid any conflicts.

@octalmage
Copy link
Owner

I'm just going to merge and fix the style inconsistencies.

Thanks again!

octalmage added a commit that referenced this pull request May 27, 2015
Enhancements to Keyboard Functions (keyToggle).
@octalmage octalmage merged commit 95dd0ba into octalmage:master May 27, 2015
@spatializes
Copy link
Contributor Author

Sorry about the inconsistencies. Thanks for taking care of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibly sleep after mouse/key events. Add toggle function for keyboard.
3 participants