NaN is never equal to NaN. Fixed in underscore.js and underscore-min.…

…js, updated tests in test/objects.js
octatone · Jun 12, 2010 · 0e8ca3c · 0e8ca3c
1 parent 79f65b4
commit 0e8ca3c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/test/objects.js b/test/objects.js
@@ -54,7 +54,9 @@ $(document).ready(function() {
     ok(_.isEqual(moe, clone), 'deep equality is true');
     ok(_(moe).isEqual(clone), 'OO-style deep equality works');
     ok(!_.isEqual(5, NaN), '5 is not equal to NaN');
-    ok(_.isEqual(NaN, NaN), 'NaN is equal to NaN');
+	ok(NaN != NaN, 'NaN is not equal to NaN (native equality)');
+	ok(NaN !== NaN, 'NaN is not equal to NaN (native identity)');
+    ok(!_.isEqual(NaN, NaN), 'NaN is not equal to NaN');
     ok(_.isEqual(new Date(100), new Date(100)), 'identical dates are equal');
     ok(_.isEqual((/hello/ig), (/hello/ig)), 'identical regexes are equal');
     ok(!_.isEqual(null, [1]), 'a falsy is never equal to a truthy');

diff --git a/underscore-min.js b/underscore-min.js
diff --git a/underscore.js b/underscore.js
@@ -469,7 +469,7 @@
     // Check dates' integer values.
     if (_.isDate(a) && _.isDate(b)) return a.getTime() === b.getTime();
     // Both are NaN?
-    if (_.isNaN(a) && _.isNaN(b)) return true;
+    if (_.isNaN(a) && _.isNaN(b)) return false;
     // Compare regular expressions.
     if (_.isRegExp(a) && _.isRegExp(b))
       return a.source     === b.source &&