Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic JVM detection #87

Closed
apjanke opened this issue Jul 1, 2018 · 6 comments
Closed

Dynamic JVM detection #87

apjanke opened this issue Jul 1, 2018 · 6 comments
Assignees

Comments

@apjanke
Copy link
Contributor

apjanke commented Jul 1, 2018

Right now, Octave on macOS is built against a specific version and update of the JVM.

See if we can get upstream to add in dynamic JVM detection, and pull that in as a patch.

References:

@apjanke apjanke self-assigned this Jul 1, 2018
@apjanke
Copy link
Contributor Author

apjanke commented Jul 1, 2018

I put together a patch to do this in upstream.

Upstream bug report: https://savannah.gnu.org/bugs/index.php?54219

@apjanke
Copy link
Contributor Author

apjanke commented Jul 23, 2018

Moved the milestone for this to The Future. It requires upstream Octave changes, and these didn't make it in to Octave 4.4.0 or 4.4.1.

@apjanke
Copy link
Contributor Author

apjanke commented Dec 5, 2018

Sigh. This is even more of an inconvenience than I thought: Oracle does not provide downloads for the older versions of JDK 8. They're up to JDK 8 u191 now, so the JDK 8 u181 installer is no longer available for download. But our Octave 4.4.0 release was built against JDK 8 u181. Which means that users who haven't happened to have previously installed JDK 8 u181 don't have a way of getting Java to work with our 4.4.0 distribution.

I think this applies to the Homebrew-supplied bottles for Octave, too.

I'll nudge upstream on this when I have some spare time.

@apjanke
Copy link
Contributor Author

apjanke commented Dec 5, 2018

Upstream has added support for JAVA_HOME, so at least we could detect and set that in our launcher wrapper script: https://savannah.gnu.org/bugs/?40111. It'll be available in 5.0.

@apjanke
Copy link
Contributor Author

apjanke commented Dec 5, 2018

Moving this to Low priority, since I haven't seen any users asking for better Java support.

@apjanke
Copy link
Contributor Author

apjanke commented Apr 9, 2019

Upstream merged a patch to fix this; it'll come out in the next major Octave release. Closing as fixed.

@apjanke apjanke closed this as completed Apr 9, 2019
@apjanke apjanke transferred this issue from octave-app/octave-app-bundler Oct 20, 2019
This was referenced Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant