Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Twig as parser for scaffolding stub contents #415

Merged
merged 2 commits into from Aug 19, 2019

Conversation

Samuell1
Copy link
Member

This allows usage of twig in stub files for scaffolding.

Allows to create dynamic commands in one stub file, mostly needed for this issue:
octobercms/october#2833

This should not be breaking change because stub files already using same variable definition like twig.

@Samuell1 Samuell1 changed the title Use Twig as parser for stub contents Use Twig as parser for scaffolding stub contents Jul 17, 2019
@LukeTowers LukeTowers added this to the v1.0.458 milestone Jul 17, 2019
@LukeTowers LukeTowers requested a review from w20k July 26, 2019 11:02
@LukeTowers LukeTowers modified the milestones: v1.0.458, v1.0.457, v1.0.459 Jul 26, 2019
@w20k
Copy link
Contributor

w20k commented Jul 29, 2019

@LukeTowers works great, nothing to report!
Status - Tested ✅

Commands used:

php artisan create:plugin Acme.Blog
php artisan create:component Acme.Blog Post
php artisan create:model Acme.Blog Post
php artisan create:controller Acme.Blog Posts
php artisan create:formwidget Acme.Blog CategorySelector
php artisan create:command RainLab.Blog MyCommand

Screenshot:
Screenshot 2019-07-29 at 19 55 54

@LukeTowers
Copy link
Contributor

Great, ping me again when we've released 458 so I can merge this in.

@Samuell1
Copy link
Member Author

@LukeTowers pinging you back

@bennothommo bennothommo merged commit 927162f into octobercms:develop Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants