Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MorphPivot #534

Closed
wants to merge 3 commits into from
Closed

Add MorphPivot #534

wants to merge 3 commits into from

Conversation

Rike-cz
Copy link
Contributor

@Rike-cz Rike-cz commented Oct 24, 2020

octobercms/october#3090
Basically it's a copy of Laravel MorphPivot with integration to October MorphToMany relationship in compliance with October BelongsToMany example.
I also added missing using param to October BelongsToMany.

@Rike-cz Rike-cz changed the title [WIP] Add MorphPivot Add MorphPivot Oct 29, 2020
@Rike-cz Rike-cz marked this pull request as ready for review October 29, 2020 07:41
@bennothommo bennothommo added this to the v1.1.1 milestone Oct 29, 2020
@bennothommo
Copy link
Contributor

bennothommo commented Oct 29, 2020

@Rike-cz would you be willing to provide some test cases for this functionality? You could probably borrow some of Laravel's tests if this functionality is mostly ported from Laravel.

@Rike-cz
Copy link
Contributor Author

Rike-cz commented Nov 15, 2020

I have a draft of tests but I am not sure if it's acceptable. @bennothommo is now busy, so if anyone is be able to tell me what to improve, I appreciate that help.

@LukeTowers
Copy link
Contributor

We also need docs for this please

@github-actions
Copy link

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

@Rike-cz
Copy link
Contributor Author

Rike-cz commented Mar 10, 2021

I think this is important, because Morph Pivot missing in October CMS library.

@daftspunk
Copy link
Member

Thanks @Rike-cz, agreed. I have reviewed these changes and they will be available in the next release. Sorry for the delay in processing this

@daftspunk daftspunk closed this Mar 10, 2021
@Rike-cz
Copy link
Contributor Author

Rike-cz commented Mar 10, 2021

@daftspunk No problem, I was afraid of damned "Archived" status. It looks like "sorry, this PR is useless, forget it" :-)

@Rike-cz Rike-cz deleted the patch-1 branch March 10, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants