-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MorphPivot #534
Add MorphPivot #534
Conversation
@Rike-cz would you be willing to provide some test cases for this functionality? You could probably borrow some of Laravel's tests if this functionality is mostly ported from Laravel. |
I have a draft of tests but I am not sure if it's acceptable. @bennothommo is now busy, so if anyone is be able to tell me what to improve, I appreciate that help. |
We also need docs for this please |
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
I think this is important, because Morph Pivot missing in October CMS library. |
Thanks @Rike-cz, agreed. I have reviewed these changes and they will be available in the next release. Sorry for the delay in processing this |
@daftspunk No problem, I was afraid of damned "Archived" status. It looks like "sorry, this PR is useless, forget it" :-) |
octobercms/october#3090
Basically it's a copy of Laravel MorphPivot with integration to October MorphToMany relationship in compliance with October BelongsToMany example.
I also added missing
using
param to October BelongsToMany.