Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error when line in version.yaml to long #1816

Closed
Codenator81 opened this issue Feb 27, 2016 · 4 comments
Closed

error when line in version.yaml to long #1816

Codenator81 opened this issue Feb 27, 2016 · 4 comments

Comments

@Codenator81
Copy link

When in plugin version.yaml file one line too long got error when install plugin.
May be we can trim it if too long?

[Illuminate\Database\QueryException]
SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'detail' at row 1 (SQL: insert into system_plugin_history (code, type,
version, detail, created_at) values (KurtJensen.MyCalendar, comment, 1.1.5, !!! This is an important update that contains breaking changes. MyCalend
ar will now be using Passage Permission Keys for permissions and you will need to install the plugin using code "kurtjensen.passage" if you use permission
s for your events. If you do not install Passage Permission Keys plugin then your protected events may not show or may be visible to anyone who visits you
r site until you do add PassagePermission Keys plugin. This update also added raw data element to event array and applied config date/time to all componen
ts., 2016-02-27 22:58:02))

[PDOException]
SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'detail' at row 1

@firemankurt
Copy link
Contributor

FYI This worked fine on Feb 5 when I updated the same plugin. My system_plugin_history table has that entry in it.

Guessing that a fix would be to trim to 255 chars here: https://github.com/octobercms/october/blob/master/modules/system/classes/VersionManager.php#L366

@Codenator81
Copy link
Author

Sorry I not mention. I use last stable branch

@daftspunk
Copy link
Member

This is probably caused by MySQL strict mode more than anything. We will
have to change the column to TEXT to support lengthy updates like this.

On Sunday, 28 February 2016, Aleksandrs Poltarjonoks <
notifications@github.com> wrote:

Sorry I not mention. I use last stable branch


Reply to this email directly or view it on GitHub
#1816 (comment)
.

@daftspunk
Copy link
Member

This bug has been fixed via live stream:

🎥 https://youtu.be/pWsljcZruKI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants