Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?] Custom 404 page returns 200 OK header #275

Closed
DanielHitchen opened this issue Jun 10, 2014 · 4 comments
Closed

[Bug?] Custom 404 page returns 200 OK header #275

DanielHitchen opened this issue Jun 10, 2014 · 4 comments

Comments

@DanielHitchen
Copy link

If you set your own 404.htm then navigate to a none existent URL, the header returns 200 OK instead of 404 not found, yet the default 404 page does return the correct 404 header ?

Thanks to D503 over on the forum for pointing this out :)

@DanielHitchen DanielHitchen changed the title [Bug] Custom 404 page returns 200 OK header ? [Bug?] Custom 404 page returns 200 OK header ? Jun 10, 2014
@DanielHitchen DanielHitchen changed the title [Bug?] Custom 404 page returns 200 OK header ? [Bug?] Custom 404 page returns 200 OK header Jun 10, 2014
@daftspunk
Copy link
Member

Fixed by #315

@NemoD503
Copy link
Contributor

What about url /some_no_exist_url ? if nginx not rewrite to /404, it will return 200 ok (and will show 404.htm) (sory for my english)

@LouisMT
Copy link

LouisMT commented Jun 17, 2014

That's exactly what my PR fixed. Probably this fix is not in the current build, but it has been merged so it should be in one of the next builds.

If you want to try it now you can just merge the change yourself locally.

@NemoD503
Copy link
Contributor

Yes, thank You! it's my mistake, really 404 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants