Flickering on Media manager files after latest update

[haralake]

• OctoberCMS Build: ### 458
• PHP Version: 7.3
• Database Engine: MySQL
• Plugins Installed:

Description:

Flickering on Media manager files. If you open Media manager folder with a lot of files and try to scroll down to the last you will see flickering, and you are unable to select any of the files. Something i noticed is that if you resize browser window it stops flickering and is working fine. You can see this issue bellow:

Steps To Reproduce:

Just open Media manager
Create folder and upload many images
Try to scroll down to the latest
Flickering!

[bennothommo]

This has been reported by a few users on Slack, so bumping up the priority.

[haralake]

Thank you @bennothommo . If you have a lot files is impossible to work with media manager so the only quick solution for now is to downgrade.

[roojai]

I'm having this issue on a number of sites - whats the best way to downgrade?

[bennothommo]

@roojai If you upgraded via Composer, you can change the October dependencies in composer.json in your root folder to the following:

        "october/rain": "1.0.455",
        "october/system": "1.0.455",
        "october/backend": "1.0.455",
        "october/cms": "1.0.455",

[roojai]

Thanks @bennothommo but not really sure how to do that.

I use 1pilot to manage multiple site upgrades, or I just use the backend plugin updates button.

The "resize browser" fix works well for now

[panakour]

[w20k]

@bennothommo will look at it as well!

[acasar]

Same issue here... I thought it was only me :)

[w20k]

@bennothommo I know what component causes the issue, will dig dipper.
scrollpad (.scrollpad-scrollbar > .drag-handler`) -> is the culprit here.

[LukeTowers]

@w20k in case it helps I've seen this happen on Facebook too just now, except much more aggressively and vertically instead of horizontally on the latest chrome.

[pavelmgn]

temporary fix

div[data-control="media-manager"] .control-scrollpad {
	position: relative;
    max-height: 500px;
    overflow: hidden;
}

[bennothommo]

I personally have been unable to replicate this on Linux running Chrome 76 and Firefox 69.

Is this happening on a particular browser or OS? Is it happening just for the Media tab in the main menu, or the media finder when adding images to a widget? Is there a specific amount of files it needs before the bug manifests?

[pavelmgn]

@bennothommo i have windows 10, chrome ver 76.0.3809.132 (Official build), (64 bit). The problem is relevant wherever the media window is used.

[roojai]

Im on the same set up as @pavelmgn. @bennothommo I have noticed that the problem does not occur in media manager itself, but when you access media through a form from another plugin. I find it only effects the lower part of the page (more than 7 files needed in list mode, 4 rows needed in small grid mode, and effects can be seen in second row in large grid mode)

[bennothommo]

@pavelmgn @roojai would either of you be willing to test it with smooth scrolling disabled in your browser and see if it makes a difference?

[ghost]

I use Google Canary and I know the last few months I have seen loads of scrolling bugs and even reported it to Google.

I would be interested to know if you install Google Canary, found here: https://www.google.com/chrome/canary/

And see if the issue still continues? As Google Canary V78 has fixed the scrolling bugs (most of them).

And this issue I saw a few months back when Google Canary was using V76.

---

Timeline of Chrome errors with scrolling I've seen was like this:

V76 - 100% scrolling errors.
V77 - 50% scrolling errors fixed.
V78 - 90% scrolling errors fixed.

---

It's even worse on Edge browser, see here: #4417

But I closed that issue down as the Edge project is dead and they switched over to using Chromium now.

---

[edit] My point is that you need test the issue to see if it's to do with October or Chrome or both.

(I didn't bother reporting it weeks ago as I saw it was to do with Chrome).

[pavelmgn]

@bennothommo no difference =( With smooth scrolling disabled, the same thing happens.

[roojai]

Seems more Chrome related than OctoberCMS, I am having the same problem on a site that is on build 447

[bennothommo]

@roojai I'm leaning towards that too, given what I've read about these types of issues with Chrome (I still haven't been able to replicate myself). Just to narrow this issue down further, can you test it with Firefox and let me know if that exhibits the same issue?

[ghost]

@bennothommo When I reported this issue to Chrome 2 months ago the Chrome team told me it's an issue with the "hardware acceleration" inside Chrome. Maybe people can try disabling it.

Not sure if this was the tag:

chrome://flags/#disable-accelerated-video-decode

p.s. for me it didn't work on a windows 10. But others said it worked on a MAC.

[edit] The solution decided upon was basically the Chrome hardware acceleration and the windows one had an issue working together. When I saw the gifs here, they look exactly the same as what I saw 2 months ago.

[bennothommo]

Thanks @ayumihamsaki. @roojai @pavelmgn, could you try @ayumihamsaki's suggestion and see if it makes a difference?

[Grawl]

@pavelmgn yep, it's a problem with this workaround. You can try to set position: sticky; top : 0 for [data-control="preview-sidebar"]. (I just tried this but with no luck)

[vangar02]

We've got a lot of October sites and clients are complaining. But it is indeed a chrome issue.

There's a quick fix. Just paste this in your Settings > Customize Back-End > Styles tab.

body div[data-control="media-manager"] .control-scrollpad{position:static}

When chrome fixes this bug, just remove it again.

[Grawl]

I just set fixed height for scroll wrapper and got October's scroll behaviour without flickering.

So, full workaround looks like this:

modules/backend/widgets/mediamanager/assets/css/mediamanager.css

-div[data-control="media-manager"] .control-scrollpad{position:absolute;left:0;top:0}
-div[data-control="media-manager"] .scroll-wrapper{position:relative}
+div[data-control="media-manager"] .scroll-wrapper{height:calc(100vh - 300px)}

Or you can add following stylesheet to Settings › Customize Back-End › Styles:

div[data-control="media-manager"] .control-scrollpad{position:static}
div[data-control="media-manager"] .scroll-wrapper{height:calc(100vh - 300px)}

[roojai]

body div[data-control="media-manager"] .control-scrollpad{position:static}

Is working for me ok.

div[data-control="media-manager"] .control-scrollpad{position:static}
div[data-control="media-manager"] .scroll-wrapper{height:calc(100vh - 300px)}

Gives me a blank page in media manager

[Grawl]

Please tell me what browser you are using to get this issue

[roojai]

Sorry, I am using chrome Version 76.0.3809.132 (Official Build) (64-bit) on windows

[iboved]

@bennothommo I have just updated my Google Chrome to 77.0.3865.75 version. And I still have the same problem.

[Farrow]

Thanks to Grawl for the CSS needed to fix the issue. The backend updates didn't work for me, but the mediamanager.css file updates did.

As a note for others though, you'll also need to update modules/backend/widgets/mediamanager/assets/less/mediamanager.less

if you use the October less compiler (like we do for our deployment process). If you don't update the less file then if you run "php artisan october:util compile [assets|less]" then the mediamanger.css file will be overwritten.

-    .control-scrollpad {
-       position: absolute;
-        left: 0;
-        top: 0;
-    }

    .scroll-wrapper {
-        position: relative;
+        height: calc(~"100vh - 300px");
    }

Note that the calc has a ~ in there so that the less compiler doesn't try to evaluate the expression at build time. Without it you end up with the wrong css.

[LukeTowers]

@iboved

I have just updated my Google Chrome to 77.0.3865.75 version. And I still have the same problem.

It's reported fixed in Chrome 78.

[Grawl]

Latest stable is 77

[LukeTowers]

@Grawl please try updating to 78 and see if it has been fixed.

[ghost]

Ok PR submitted.

There were two issues causing the error, these are as follows:

1. The issue was the position using absolute and not sticky, which caused a forever scrolling action. Position: sticky has fixed this issue.

2. The issue here was because the scrollbar javascript in the media manager needs to have the right sidebar displayed and the css was using display: none, switching it over to opacity: 0 allows the javascript to scroll the container. If you set the display to none you will see the data-visible attribute keep trying to set it to true and the screen starts flickering! The right sidebar in the media manager is the place where the media file previews are displayed.

Please can some people test out my PR and shout at me - when needed, pr is here: #4632

[Grawl]

Just checked for updates and it's still 77

[SebastiaanKloos]

Chrome update 78 fixed it for me

[haralake]

I confirm that chrome v.78 has fixed this issue

[LukeTowers]

Great, will leave it open until 460 is released at least

[github-actions]

This issue will be closed and archived in 3 days, as there has been no activity in the last 30 days. If this issue is still relevant or you would like to see action on it, please respond and we will get the ball rolling.

[SebastiaanKloos]

@LukeTowers Issue still fixed with 78.0.3904.108

[summercms]

⚠️Warning ⚠️ As of December 2019 there is an issue in the Firefox browser with the media manager, see video of the error here: https://youtu.be/Rlq9R3WIDfQ

If you or your clients use Firefox, I suggest adding this commit to fix it: 1e449c8

🔥🔥🔥