Fix Security issue in media manager #3604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is a way to manipulate folder names using the request headers for the medafinder folder path. since `validatePath` does not validate file names but rather only validates the existence of a folder in a parent/subdirectory. We can utilize `validateFileName` to verify if the name of the folder path being created is valid during the folder creation process and the name applying process.
variable renaming so it would make sense
|
Awesome @teranode! Could you please add some tests for invalid vs valid paths? |
|
@LukeTowers I have like 0 idea on how to do that :( -> I've never concerned myself with doing unit testing or creating a test file. I just use the issue live and then fix it live. :/ Sorry about that. |
|
@teranode no worries, basically you would add to https://github.com/octobercms/october/blob/master/tests/unit/system/classes/MediaLibraryTest.php to test a valid path to make sure it passes validation and test an invalid path to make sure it fails validation. If you don't want to give it a try let me know and I will take care of it for you |
|
All good, I'll get it. Thanks @teranode |
|
Ill let u handle that :| |
daftspunk
added a commit
that referenced
this pull request
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a way to manipulate folder names using the request headers for the medafinder folder path. Since
MediaLibrary::validatePath()does not validate folder names but rather only validates the existence of a folder as a parent directory or subdirectory. Using that manipulation, if the folder does not exist as a parent directory or subdirectory, the folder will be created using the path query.We can utilize
$this->validateFileName()to verify if the name of the folder path name being used for the folder name is valid during the folder creation function and the name applying function for the path query.