Prevent plugins that cannot be instantiated from being loaded

[bennothommo]

Per @LukeTowers suggestion here, this functionality wraps a portion of the loadPlugin function with a try..catch block. If, for any reason, the plugin cannot be instantiated (for example, if a parse error occurs or reserved keywords are used in the namespace), instead of bricking the site, this will simply prevent the plugin from being loaded.

[LukeTowers]

This is great @bennothommo! Could we either throw an exception or log an error when an invalid plugin is detected instead of just chugging along as if nothing happened though? What are your thoughts on that?

[bennothommo]

@LukeTowers Good idea. I did try having some logging originally, however, when it was using a translatable string it caused all the system translation strings to remain untranslated. I can only assume that when the plugins are loaded, the translator isn't fully operational at that point. It does work when using a static string however.

[LukeTowers]

I'm fine with a static string, at least then people would be able to google the issue. And yes, that issue does happen when attempting to use the translator before everything finishes loading, I've had to wrap code that uses the translator directly in App::before() to get it working properly but I don't think that would work in this case.

[bennothommo]

Error log now in place :)

[LukeTowers]

Great job @bennothommo, thanks very much!