Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for nested Repeater/MLRepeater usage #56

Merged
merged 1 commit into from Apr 17, 2019

Conversation

jimcottrell
Copy link
Contributor

This shows a couple of issues with repeaters that should be addressed by octobercms/october#3729 and rainlab/translate-plugin#409.

A couple of repeater groups have been added to Countries > Content. The one named Recurse allows for arbitrary levels of nesting. Currently, two levels of nesting can be added, but attempts to save the form throw an error. Attempting to add another level of nesting will similarly fail.

The Tag list group adds a taglist widget in string mode. Because repeaters are currently returning the raw form data via getSaveValue, a child taglist will never have a chance to process the save data. After adding tags to a taglist and saving, an exception will be thrown on reloading the page, as the saved value is the raw array rather than the expected string.

Both Countries > Content and Countries > States conditionally support RainLab.Translate so that MLRepeater functionality can also be verified with group and non-group usage.

@LukeTowers
Copy link
Contributor

LukeTowers commented Apr 6, 2019

This needs to be re-evaluated in lite of octobercms/october#4234 and rainlab/translate-plugin#466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants