Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve “Add to homescreen” icon #1713

Closed
andrew opened this issue Apr 1, 2019 · 11 comments · Fixed by #1720
Closed

Improve “Add to homescreen” icon #1713

andrew opened this issue Apr 1, 2019 · 11 comments · Fixed by #1720
Labels
design Visual and UX related items enhancement Improvements and features help wanted Contributions welcome

Comments

@andrew
Copy link
Member

andrew commented Apr 1, 2019

E3A62AC6-43DA-40FD-B2D6-3E0F6FAF7E12

When you add Octobox to your homescreen on iOS 12.2 you get an ugly white border on the icon, probably better to have a black square for that.
@andrew andrew added enhancement Improvements and features help wanted Contributions welcome design Visual and UX related items labels Apr 1, 2019
@GiacomoLaw
Copy link
Contributor

GiacomoLaw commented Apr 2, 2019 •
edited

So the icon shouldn't have the white border? Odd as the Apple icons in the folder mean that it shouldn't have the border 😕

@andrew
Copy link
Member Author

andrew commented Apr 2, 2019

@GiacomoLaw looks like it's using https://octobox.io/apple-icon-144x144.png which is round

@GiacomoLaw
Copy link
Contributor

Ah, okay. I can make it all grey when I get home if you would like.

@GiacomoLaw
Copy link
Contributor

Sorry, forgot to do today. Will do it again tomorrow afternoon. Sorry about that!

@BenJam Octobox
Copy link
Contributor

BenJam commented Apr 3, 2019

Just in case it's useful: I wrote a quick script to generate icons over at https://github.com/octobox/octobox/blob/master/bin/generate_icons.sh

@GiacomoLaw
Copy link
Contributor

That’s great. Can I use that for other sites?

@BenJam Octobox
Copy link
Contributor

BenJam commented Apr 3, 2019

Sure, do you need me to push it elsewhere under a non aGPL ?

@GiacomoLaw
Copy link
Contributor

GiacomoLaw commented Apr 3, 2019 •
edited

Sorry, I don't understand...

@BenJam Octobox
Copy link
Contributor

BenJam commented Apr 3, 2019

No worries, use it however you like.

@GiacomoLaw
Copy link
Contributor

Awesome, appreciate it. Thank you!

@GiacomoLaw GiacomoLaw mentioned this issue Apr 3, 2019
Merged
andrew pushed a commit that referenced this issue Apr 4, 2019
@GiacomoLaw @andrew
updated apple icon (#1720)
e179eb6 
resolves #1713
@andrew
Copy link
Member Author

andrew commented Apr 4, 2019

@GiacomoLaw thanks for tackling this 👍

andrew pushed a commit that referenced this issue May 13, 2019
@GiacomoLaw @andrew
updated apple icon (#1720)
bfd9129 
resolves #1713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design Visual and UX related items enhancement Improvements and features help wanted Contributions welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated apple icon
3 participants
@andrew @BenJam @GiacomoLaw