Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of contrast in the dark theme #959

Closed
2 tasks done
jules2689 opened this issue Sep 17, 2018 · 0 comments
Closed
2 tasks done

Lack of contrast in the dark theme #959

jules2689 opened this issue Sep 17, 2018 · 0 comments
Labels
design Visual and UX related items

Comments

@jules2689
Copy link
Contributor

jules2689 commented Sep 17, 2018 •
edited by BenJam

Are you experiencing this issue in octobox.io or your own instance?

  • octobox.io
  • My instance

馃悶 Problem
Dark Theme's active rows is too low of a contract from normal rows. Same with hover state.

image

馃幆 Goal

More legibility

馃挕 Possible solutions

For active, maybe something like #3b3b54
For hover, maybe something like #3b3b5466

image

cc @andrew @BenJam
@andrew andrew added the design Visual and UX related items label Sep 17, 2018
BenJam added a commit that referenced this issue Sep 21, 2018
@BenJam
* brighten up main notification table
9d60c27 
fixes #959
@BenJam BenJam mentioned this issue Sep 21, 2018
Merged
@andrew andrew closed this as completed in 0832d8f Sep 22, 2018
jonpulsifer pushed a commit to Shopify/octobox that referenced this issue Oct 3, 2018
@BenJam @jonpulsifer
Design tweaks (octobox#992)
01b9b9e 
* * brighten up main notification table

fixes octobox#959

* * tone down blue

// fixes 846

* * stop long, unbreakable repo and author names gobbling layout

// fixes octobox#988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design Visual and UX related items
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrew @jules2689