Status webhooks should update subects with combined status result #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew
force-pushed
the
sync-subject-refactor
branch
from
c977093
to
fefc85e
Compare
2 tasks
|
👍 |
coreyja
added a commit
to coreyja/octobox
that referenced
this pull request
Oct 16, 2018
* 'master' of github.com:coreyja/octobox: (56 commits) Add Guard gem and config (octobox#1111) Bump xpath from 3.1.0 to 3.2.0 (octobox#1107) Bump jwt from 1.5.6 to 2.1.0 (octobox#1104) Bump autoprefixer-rails from 9.1.4 to 9.2.0 (octobox#1103) Bump i18n from 1.1.0 to 1.1.1 (octobox#1102) Bump mail from 2.7.0 to 2.7.1 (octobox#1101) Refactor user validations (octobox#1090) Bump oauth2 from 1.4.0 to 1.4.1 (octobox#1100) Tiny typo fix in notification model test (octobox#1099) Show first few lines of issue/pr body as title on notification links (octobox#1097) Fix typo for Unlabelled filter (octobox#1098) Subject syncing is now live on Octobox.io Sync subject body for issues and pull requests (octobox#1094) Ensure locked field is updated when existing subjects are updated (octobox#1096) Status webhooks should update subects with combined status result (octobox#1093) Fix dropdown svg icons colors Bump octokit from 4.12.0 to 4.13.0 (octobox#1091) Fixed sidebar colors (octobox#1079) Rubocop fixes (octobox#1075) Prompt users to log into the GitHub App (octobox#1078) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1089
Had to do a bit of refactoring of the subject status syncing to be able to sync the combined status for a subject on receiving a
Statuswebhook without a known notification/user.For GitHub App setups (https://octobox.io), this creates an Installation Access Token to make the request, otherwise it uses the first user who appears to have access to the subject.
Also took the opportunity to deleted some unused subject methods and tests and reorganized the
SyncSubjectmodule.