Fix javascript error when opening external subject links #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should only try to pushstate for links that open a threadview, not external links
coreyja
added a commit
to coreyja/octobox
that referenced
this pull request
Nov 24, 2018
…thub-client-refactors-for-pat * 'master' of github.com:octobox/octobox: (27 commits) Uncheck all selected notifications after "Mark as Read" is done (octobox#1293) Remove some console.logs from search suggestions js (octobox#1291) Add a linked button to reply on GitHub to bottom of threads (octobox#1288) remove redundant .subject-link class (octobox#1292) Fix javascript error when opening external subject links (octobox#1290) Turn off autocomplete on all checkboxes (octobox#1289) Allow deleting notifications from search results (octobox#1287) Bump simple_form from 4.0.1 to 4.1.0 (octobox#1286) Disambiguate 'installing' from 'signing in' (octobox#1280) Only attempt to sync users who have an access token (octobox#1283) Involved users should always be ones that haven't been recently synced (octobox#1282) Skip enqueuing repository sync tasks if repo exists (octobox#1281) Skip syncing the repository if it's already present (octobox#1279) Use update rather than update_attributes when saving existing repos (octobox#1278) Add initial action_cable setup (octobox#1080) Enable momentum scrolling in thread view on iOS (octobox#1274) Always expand the last comment in a thread (octobox#1272) Show a spinner when loading a thread view (octobox#1271) Order comments from oldest to newest (octobox#1270) Order comments by date rather than ID (octobox#1269) ... # Conflicts: # app/models/subject.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should only try to pushstate for links that open a thread view, not external links.