Use _blank when opening external links #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clicking the status button in the upper left of a thread view it links you to the external github item, however, it uses 'blank' instead of '_blank' for the href attribute. This means that if I: Click the status button to view something in github Navigate away to do something else with that tab Go back to octobox to view a thread Click the status button again Chrome will just activate the previously used tab instead of navigating the user to the item on github
andrew
pushed a commit
that referenced
this pull request
May 13, 2019
When clicking the status button in the upper left of a thread view it links you to the external github item, however, it uses 'blank' instead of '_blank' for the href attribute. This means that if I: Click the status button to view something in github Navigate away to do something else with that tab Go back to octobox to view a thread Click the status button again Chrome will just activate the previously used tab instead of navigating the user to the item on github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking the status button in the upper left of a thread view it links you to the external github item, however, it uses 'blank' instead of '_blank' for the href attribute. This means that if I:
Click the status button to view something in github
Navigate away to do something else with that tab
Go back to octobox to view a thread
Click the status button again
Chrome will just activate the previously used tab instead of navigating the user to the item on github