Refactor subject model #2070
Merged
Refactor subject model #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyStabler
force-pushed
the
refactor-subject-model
branch
3 times, most recently
from
14327c4
to
655566f
Compare
|
Looking good @AndyStabler 👍 |
AndyStabler
force-pushed
the
refactor-subject-model
branch
3 times, most recently
from
ebc7cce
to
a27ff97
Compare
AndyStabler
commented
Oct 22, 2019
| sync_involved_users if (saved_changes.keys & notifiable_fields).any? | ||
| end | ||
|
|
||
| def self.sync(remote_subject) |
There was a problem hiding this comment.
How do you feel about having an instance and a class method with the same name? We can change this to something else if we like I'm just wary of changing too much in one PR.
There was a problem hiding this comment.
I don't mind that, I've done it a lot in the past
Lots of the stuff going on inside the Subject.sync method is acting on an instance and not doing things at the class level. This commit extracts a Subject#sync instance method to make things more object oriented and to allow us to start extracting the logic out of this method. This should hopefully make things easier to understand what's going on.
AndyStabler
force-pushed
the
refactor-subject-model
branch
from
a27ff97
to
fac7705
Compare
|
Thanks for taking a look @andrew 🙇 I've cleaned things up and it's ready for review! |
andrew
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started a refactor of the subject class aages ago and I'm finally getting round to looking at it again.
I'd like to poke the
syncmethod to see what it looks like when it's working on an instance ofsubjectinstead of operating at a class level.