New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openapi.yaml to the repository. #3633
base: master
Are you sure you want to change the base?
Conversation
Looking good, thanks for tackling this, I've just merged an update that fixes running octobox via docker-compose, so that may solve some of the issues you were running into. |
Thanks for the update! I verified that Swagger's curl command works for I'm happy to work on this as long as is useful, by the way, as I'm trying to get my API documentation chops together. |
It could well be broken, although all the tests are passing which makes me think it’s a config issue, I’ll also give them a try tomorrow. This is really helpful, thanks for contributing |
Hi there: Just an update that I tried those commands using my live Octobox URL rather than Docker. While this didn't return HTML in terminal, I still wasn't able to post or patch pinned notifications using CURL. Additionally, I'm also still not sure whether syncing feature is working or not. |
Hi there! Just following up to ask if you'd had a chance to look at those endpoints and/or any instructions for to continuing working on the API documentation. |
Sorry for the delay, I’ll review this later tonight |
I've added some inline comments, it's looking good so far, the schemas could do with a bit of tweaking to seperate the different objects and use the Example: https://github.com/ecosyste-ms/packages/blob/main/openapi/api/v1/openapi.yaml#L1103 I could get all of the api endpoints working, a couple return 200 instead of 204, the creating and updating of pinned searches is a bit confusing as it follows the rails convention for parameters, I left examples in the comments above. |
I also opened up the file in https://editor.swagger.io, all working and no errors! |
Thanks for this feedback! It's really helpful on my end. I'll start working on your recommendations and check in once I've finished the revisions. |
Co-authored-by: Andrew Nesbitt <andrewnez@gmail.com>
Co-authored-by: Andrew Nesbitt <andrewnez@gmail.com>
Co-authored-by: Andrew Nesbitt <andrewnez@gmail.com>
Hi there: Just touching base to see whether there is more work I can do on this. No rush on my end! |
@rickwysocki nothing more needed from your right now, I'm travelling for work at the moment, hope to get back to this in about a week |
I created an openapi.yaml spec file for Octobox. I relied both on existing documentation and my own testing of the endpoints in a Docker version of the application. I have a points/questions to review:
This was a lot of fun! I'd love to keep working on this with your feedback on the current version.
EDIT: One last point I forgot to mention: I was unsure where the openapi.yaml file should go, so it is in the root directory.