Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #919 Allow filtering by multiple repositories with search p… #921

Merged
merged 1 commit into from Sep 13, 2018
Merged

Addresses #919 Allow filtering by multiple repositories with search p… #921

merged 1 commit into from Sep 13, 2018

Conversation

prashuchaudhary
Copy link
Contributor

…refix

@gbp
Copy link

gbp commented Sep 12, 2018

This is great, I've tested this and it works!

One thing I noticed, if you check for sub_scope == :repo here it would also allow this to be used when accessing /?repo=a%2Fb%2Cb%2Fc.

Copy link
Member

@andrew andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👌

@prashuchaudhary
Copy link
Contributor Author

@gbp Making a request like this /?repo=a%2Fb%2Cb%2Fc will return No Results, which is correct behavior given that it lists all the Unread notification of a repo.

What would you suggest should be done here ??

@andrew andrew merged commit d830c9e into octobox:master Sep 13, 2018
andrew added a commit that referenced this pull request Sep 13, 2018
* master: (132 commits)
  Addresses #919 Allow filtering by multiple repositories with search prefix (#921)
  * make all svg's $body-color (#920)
  Revert "Ignore the docs folder when generating docker images or heroku slugs" (#918)
  Dark mode (#769)
  Ignore the docs folder when generating docker images or heroku slugs (#916)
  Small tweaks to github app settings section (#915)
  Bump uglifier from 4.1.18 to 4.1.19 (#914)
  Bump octokit from 4.11.0 to 4.12.0 (#912)
  Don't show full list of repositories with app installed in settings (#911)
  Sync install permissions along with notifications (#909)
  Show installed github apps on user settings page (#910)
  Add vulnerability disclosure policy (#908)
  Sync GitHub App installations that a user has access to manage (#907)
  Bring back #891 (#905)
  Revert "Add sorting to notifications (#891)" (#904)
  Add sorting to notifications (#891)
  Add repository_full_name index on notifications table (#902)
  Bump bootsnap from 1.3.1 to 1.3.2
  Ensure there's always an updated_at set on notifications
  Add Octobox.github_app_client for making API requests as the GitHub App (#901)
  ...
andrew added a commit that referenced this pull request Sep 13, 2018
* master: (35 commits)
  Show action buttons on hover of notification row (#823)
  Svg & card header fixes (#922)
  Addresses #919 Allow filtering by multiple repositories with search 
prefix (#921)
  * make all svg's $body-color (#920)
  Revert "Ignore the docs folder when generating docker images or heroku 
slugs" (#918)
  Dark mode (#769)
  Ignore the docs folder when generating docker images or heroku slugs 
(#916)
  Small tweaks to github app settings section (#915)
  Bump uglifier from 4.1.18 to 4.1.19 (#914)
  Bump octokit from 4.11.0 to 4.12.0 (#912)
  Don't show full list of repositories with app installed in settings 
(#911)
  Sync install permissions along with notifications (#909)
  Show installed github apps on user settings page (#910)
  Add vulnerability disclosure policy (#908)
  Sync GitHub App installations that a user has access to manage (#907)
  Bring back #891 (#905)
  Revert "Add sorting to notifications (#891)" (#904)
  Add sorting to notifications (#891)
  Add repository_full_name index on notifications table (#902)
  Bump bootsnap from 1.3.1 to 1.3.2
  ...
jonpulsifer pushed a commit to Shopify/octobox that referenced this pull request Oct 3, 2018
jonpulsifer added a commit to Shopify/octobox that referenced this pull request Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants