Resolve AXFR host if DNS name is supplied #22
Conversation
| try: | ||
| h = dns.resolver.resolve(host)[0].address | ||
| except DNSException as err: | ||
| raise AxfrSourceZoneTransferFailed(err) from None |
There was a problem hiding this comment.
Interesting. Hadn't run across the from None thing before.
There was a problem hiding this comment.
This was the relevant thing I found for it https://stackoverflow.com/questions/52725278/during-handling-of-the-above-exception-another-exception-occurred
In this case the checking of the IP address calls like inet.aton which throws a SyntaxError, which then I think isn’t caught or something, but then the calling method throws a ValueError. You end up doing from None to silence the “inner” exceptions (SyntaxError) for the outer one (ValueError)
Other cool thing I found was autospec https://docs.python.org/3/library/unittest.mock.html#auto-speccing
Didn’t end up using it but played around with it figuring out the tests for this.
Addresses #18
In our documentation we reference using a DNS name, which actually was not functional and wildly it never came up until recently. dnspython's
dns.query.xfranddns.query.tcpexpect an IP address to perform actions against otherwise it will error, it does not handle resolving it on it's own.This change adds a quick check to see if the host supplied by the user is an IPv4/IPv6 addresses or a DNS name, and if a DNS name is supplied it will resolve it to an IP to be passed off to
dns.query.xfranddns.query.tcpProbably after #5 and this are merged will cut a new release