_build_kwargs fix, don't convert int-y things to floats

octodns · Mar 8, 2024 · 4b229fb · 4b229fb
1 parent 3acfd17
commit 4b229fb
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/octodns/manager.py b/octodns/manager.py
@@ -388,10 +388,14 @@ def _build_kwargs(self, source):
                             f'Incorrect provider config, missing env var {env_var}, {source.context}'
                         )
                     try:
-                        # try converting the value to a number to see if it
-                        # converts
-                        v = float(v)
+                        if '.' in v:
+                            # has a dot, try converting it to a float
+                            v = float(v)
+                        else:
+                            # no dot, try converting it to an int
+                            v = int(v)
                     except ValueError:
+                        # just leave it as a string
                         pass
 
             kwargs[k] = v

diff --git a/tests/test_octodns_manager.py b/tests/test_octodns_manager.py
@@ -1133,6 +1133,7 @@ def test_build_kwargs(self):
 
         environ['OCTODNS_TEST_1'] = '42'
         environ['OCTODNS_TEST_2'] = 'string'
+        environ['OCTODNS_TEST_3'] = '43.44'
 
         # empty
         self.assertEqual({}, manager._build_kwargs({}))
@@ -1202,6 +1203,18 @@ def test_build_kwargs(self):
             ),
         )
 
+        # types/conversion
+        self.assertEqual(
+            {'int': 42, 'string': 'string', 'float': 43.44},
+            manager._build_kwargs(
+                {
+                    'int': 'env/OCTODNS_TEST_1',
+                    'string': 'env/OCTODNS_TEST_2',
+                    'float': 'env/OCTODNS_TEST_3',
+                }
+            ),
+        )
+
 
 class TestMainThreadExecutor(TestCase):
     def test_success(self):