Move HTTPS to its own file, import them in octodns.record #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 sorry for missing this :) |
You had no way to know, I was the one who missed it. Figured implemeting things in octodns-powerdns would shake out things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types need to be imoprted into
octodns.recordso that they're registered and supported by default. Ran into this problem when adding support in octodns/octodns-powerdns#70.Splitting the HTTPS type out into it's own file is just a minor tweak to make it work/look a little more like all the rest of the types. It also adds a no-op HttpsValue just to make things more consistent.
/cc octodns/octodns-powerdns#70 which lead me to hit part of this.
/cc #1176 which this builds on/tweaks slightly