Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #27 from octoenergy/shorthand
Migrate emoji shorthand from private repo
- Loading branch information
Showing
2 changed files
with
48 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
# Shorthand | ||
|
||
This pages explains what the emojis used in code-review comments and Slack mean. | ||
They are shorthand for common situations. | ||
|
||
## In code review comments | ||
|
||
### π¬ | ||
Debug/commented-out code needs removing/uncommenting | ||
|
||
### π», π΅πΎ, πΌ | ||
Minor/pedantic point - short hand for: | ||
> "I know this this is deeply pedantic but..."). | ||
For comments so pedantic you're almost embarrassed to write them, wrap in `<sup>` tags. | ||
|
||
> πΌ<sup>"Direct Debit" should be title-case.</sup> | ||
"Panda-ntic" if you will. | ||
|
||
### π | ||
Please eyeball this change/commit/code: | ||
> π Hey @team, is this change ok? I'm not that familiar with $domain_concept | ||
### β»οΈ | ||
Same explanation as above (aka ditto) | ||
|
||
### π, π | ||
Yak-shaving code review comments, as in: | ||
|
||
> I know this is out of scope for this PR request but ... | ||
or something like: | ||
|
||
> I know you only renamed the file but I'm going to comment on all the green lines in the diff that you didn't write... | ||
## In Slack | ||
|
||
β - PR approved | ||
|
||
π - "I've requested changes" or "I've responded to your feedback" (back to you...) | ||
|
||
π¬ - comments added | ||
|
||
π’ - PR merged (aka shipped) | ||
|
||
π - PR can be merged immediately after passing review (ie a "slam dunk") |