Skip to content

Commit

Permalink
Merge pull request #27 from octoenergy/shorthand
Browse files Browse the repository at this point in the history
Migrate emoji shorthand from private repo
  • Loading branch information
codeinthehole committed Mar 7, 2019
2 parents 69631ef + 7b94257 commit 589f9c5
Show file tree
Hide file tree
Showing 2 changed files with 48 additions and 0 deletions.
1 change: 1 addition & 0 deletions README.md
Expand Up @@ -15,3 +15,4 @@ Contents:
- [CSS](css.md)
- [HTML and Django templates](html.md)
- [Email templates](emails.md)
- [Emoji shorthand](shorthand.md) (used in code-review and Slack messages)
47 changes: 47 additions & 0 deletions shorthand.md
@@ -0,0 +1,47 @@
# Shorthand

This pages explains what the emojis used in code-review comments and Slack mean.
They are shorthand for common situations.

## In code review comments

### πŸ’¬
Debug/commented-out code needs removing/uncommenting

### πŸ‘», πŸ•΅πŸΎ, 🐼
Minor/pedantic point - short hand for:
> "I know this this is deeply pedantic but...").
For comments so pedantic you're almost embarrassed to write them, wrap in `<sup>` tags.

> 🐼<sup>"Direct Debit" should be title-case.</sup>
"Panda-ntic" if you will.

### πŸ‘€
Please eyeball this change/commit/code:
> πŸ‘€ Hey @team, is this change ok? I'm not that familiar with $domain_concept
### ♻️
Same explanation as above (aka ditto)

### πŸ‚, πŸƒ
Yak-shaving code review comments, as in:

> I know this is out of scope for this PR request but ...
or something like:

> I know you only renamed the file but I'm going to comment on all the green lines in the diff that you didn't write...
## In Slack

βœ… - PR approved

πŸ“ - "I've requested changes" or "I've responded to your feedback" (back to you...)

πŸ’¬ - comments added

🚒 - PR merged (aka shipped)

πŸ€ - PR can be merged immediately after passing review (ie a "slam dunk")

0 comments on commit 589f9c5

Please sign in to comment.