Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): add script to fix package.json before publishing #494

Merged
merged 2 commits into from
May 16, 2023

Conversation

wolfy1339
Copy link
Member

Resolves #493


Behavior

Before the change?

The released npm package is missing most of the files generated by the build step. dist-node, dist-types, dist-web... even though they are generated correctly.

After the change?

With the corrected file patterns, npm will publish all the necessary files again.

Other information

This is a mix of an issue with npm@v9 (npm/cli#6164) and the fact we rely on pika for the build step. Pika has been archived since April 2022 so there is nothing we can do with Pika.


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Dependencies/code cleanup: Type: Maintenance

@wolfy1339 wolfy1339 added Priority: High Type: Bug Something isn't working as documented labels May 13, 2023
@ghost ghost added this to Bugs in JS May 13, 2023
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking forward to getting things unbroken here! What would you think about adding some form of docs or a link to the relevant issue to help out future me when I stumble across this script?

@wolfy1339 wolfy1339 enabled auto-merge (squash) May 16, 2023 22:10
@wolfy1339 wolfy1339 merged commit 7e56c16 into main May 16, 2023
6 checks passed
JS automation moved this from Bugs to Done May 16, 2023
@wolfy1339 wolfy1339 deleted the fix-release-workflow branch May 16, 2023 22:10
@github-actions
Copy link

🎉 This PR is included in version 5.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
Archived in project
JS
  
Done
Development

Successfully merging this pull request may close these issues.

[BUG]: @octokit/action 5.0.3 has no type definition
2 participants