Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST endpoint methods #8

Merged
merged 9 commits into from Nov 25, 2019
Merged

REST endpoint methods #8

merged 9 commits into from Nov 25, 2019

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Nov 19, 2019

No description provided.

@gr2m
Copy link
Contributor Author

gr2m commented Nov 19, 2019

That's the TypeScript error I currently get 🤷‍♂

✗ /Projects/octokit/action.js/node_modules/typescript/bin/tsc --outDir /Projects/octokit/action.js/pkg/dist-src/ -d --declarationDir /Projects/octokit/action.js/pkg/dist-types/ --project /Projects/octokit/action.js/tsconfig.json --target es2019 --module esnext --noEmit false
node_modules/@octokit/auth-action/dist-types/index.d.ts:1:10 - error TS2440: Import declaration conflicts with local declaration of 'Types'.

1 import { Types } from "@octokit/auth-token";
           ~~~~~

node_modules/@octokit/plugin-paginate-rest/dist-types/index.d.ts:1:10 - error TS2440: Import declaration conflicts with local declaration of 'PaginateInterface'.

1 import { PaginateInterface } from "./types";
           ~~~~~~~~~~~~~~~~~

src/index.ts:8:14 - error TS4023: Exported variable 'Octokit' has or is using name 'EndpointMethodsObject' from external module "/Projects/octokit/action.js/node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/types" but cannot be named.

8 export const Octokit = Core.plugin([
               ~~~~~~~

@gr2m
Copy link
Contributor Author

gr2m commented Nov 19, 2019

Looks like this is an issue with TypeScript 3.7.2 instead of the changes in this PR

@gr2m gr2m mentioned this pull request Nov 25, 2019
gr2m added a commit to octokit/plugin-rest-endpoint-methods.js that referenced this pull request Nov 25, 2019
…ing name EndpointMethodsObject from external module node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/types but cannot be named."

see octokit/action.js#8
gr2m added a commit to octokit/plugin-rest-endpoint-methods.js that referenced this pull request Nov 25, 2019
…ing name EndpointMethodsObject from external module node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/types but cannot be named."

see octokit/action.js#8
@gr2m gr2m merged commit aaa11c7 into master Nov 25, 2019
@gr2m gr2m deleted the rest-endpoint-methods branch November 25, 2019 19:26
@github-actions
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant