Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greenkeeper/@octokit/request 4.0.1 #30

Closed
wants to merge 2 commits into from

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented May 16, 2019

closes #29

@wolfy1339
Copy link
Member

wolfy1339 commented May 16, 2019

I've dug around and this is the info i came up with

State.request object { request:
   { [Function: newApi]
     endpoint:
      { [Function: bound endpointWithDefaults]
        DEFAULTS:
         { method: 'GET',
           baseUrl: 'https://api.github.com',
           headers:
            { accept: 'application/vnd.github.v3+json',
              'user-agent': 'octokit-request.js/4.0.1 Node.js/11.1.0 (Windows 10; x64)' },
           mediaType: { format: '', previews: [] } },
        defaults: [Function: bound withDefaults],
        merge: [Function: bound merge],
        parse: [Function: parse] },
     defaults: [Function: bound withDefaults] } }

Therefore, you need to do request.request in the const state definition like so:

request: baseUrl ? request.defaults({ baseUrl }) : request.request,

EDIT: Probably due to the named export

@gr2m
Copy link
Contributor Author

gr2m commented May 16, 2019

Yeah this PR needs to fixed by using the named export from the @octokit/request. Feel free :)

@wolfy1339
Copy link
Member

I would but I don't have push access. And It's included in my other PR anyways

@gr2m
Copy link
Contributor Author

gr2m commented May 16, 2019

closing in favor of #31

@gr2m
Copy link
Contributor Author

gr2m commented May 16, 2019

I would but I don't have push access.

should work now

@gr2m gr2m closed this May 16, 2019
wolfy1339 added a commit to wolfy1339/app.js that referenced this pull request May 16, 2019
To be reverted once octokit#30 is merged
@greenkeeper greenkeeper bot deleted the greenkeeper/@octokit/request-4.0.1 branch May 22, 2019 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants