Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix typescript validation test #445

Merged
merged 2 commits into from
Jan 25, 2023
Merged

tests: fix typescript validation test #445

merged 2 commits into from
Jan 25, 2023

Conversation

wolfy1339
Copy link
Member

Unblocks #444 and #443


Behavior

Before the change?

  • Typescript would fail the validation test because the typings for Node didn't include KeyObject in the crypto module, since it was using the typings for NodeJS v10. Those typings are a result of the @pika/pack which depends on that version

After the change?

  • Include @types/node as a direct dependency to fix the typescript validation test, in order to have the up to date typings

Other information

  • Also adds a setup-node step to make sure we use a recent Node version

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jan 24, 2023
@ghost ghost added this to Maintenance in JS Jan 24, 2023
@gr2m gr2m merged commit 36dbaf8 into main Jan 25, 2023
JS automation moved this from Maintenance to Done Jan 25, 2023
@gr2m gr2m deleted the wolfy1339-patch-1 branch January 25, 2023 00:51
@github-actions
Copy link
Contributor

🎉 This PR is included in version 4.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants