Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): types for octokit.hook.{before,after,error,wrap}("request", () => {}) methods #301

Merged
merged 4 commits into from
Mar 9, 2021

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Mar 5, 2021

Shout out to @MunifTanjim who made this possible via gr2m/before-after-hook#81

image

@ghost ghost added this to Inbox in JS Mar 5, 2021
@wolfy1339 wolfy1339 added Type: Feature New feature or request typescript Relevant to TypeScript users only labels Mar 5, 2021
@ghost ghost moved this from Inbox to Features in JS Mar 5, 2021
@gr2m gr2m self-assigned this Mar 6, 2021
@ghost ghost moved this from Features to In progress in JS Mar 6, 2021
@gr2m gr2m merged commit ced6249 into master Mar 9, 2021
JS automation moved this from In progress to Done Mar 9, 2021
@gr2m gr2m deleted the hook-types branch March 9, 2021 23:47
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2021

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request typescript Relevant to TypeScript users only
Projects
No open projects
JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants