Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace lolex with sinon fake-timers #635

Merged
merged 1 commit into from
Nov 20, 2023
Merged

chore: replace lolex with sinon fake-timers #635

merged 1 commit into from
Nov 20, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Nov 20, 2023 •
edited

Resolves #636

Before the change?

After the change?

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 merged commit 81953c6 into octokit:main Nov 20, 2023
8 of 9 checks passed
@Uzlopak Uzlopak deleted the replace-lolex branch November 20, 2023 18:16
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 5.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfy1339 wolfy1339 wolfy1339 approved these changes

Assignees
No one assigned
Labels
released
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MAINT]: Replace lolex with @sinon/fake-timers
2 participants
@Uzlopak @wolfy1339