Scenario: get archive #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
gr2m
force-pushed
the
scenario/get-archive
branch
3 times, most recently
from
be53b89
to
a5ae2dd
Compare
response.url is not awlays set
Also, normalization functions can now be async
gr2m
force-pushed
the
scenario/get-archive
branch
from
a5ae2dd
to
e91aad9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on nock/nock#1067
This one was a bit more challenging as the response to downloading a newly created repository is always different. I had to allow the normalization routines to be asynchronous. The archive handler untars & unzips the response, normalizes its content (folder name and mtime) then tars & zips again.