Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖🚨 1 changes in existing fixtures detected #287

Closed
wants to merge 2 commits into from

Conversation

octokitbot
Copy link
Collaborator

Dearest humans,

My friend Travis asked me to let you know that they found API changes in their daily routine check.

…orator

BREAKING CHANGE: api.github.com/add-and-remove-repository-collaborator has changed

```diff
[
   ...
   ...
   ...
   ...
   ...
-  {
-    scope: "https://api.github.com:443"
-    method: "get"
-    path: "/repos/octokit-fixture-org/add-and-remove-repository-collaborator/collaborators"
-    status: 200
-    response: [
-      {
-        login: "octokit-fixture-user-a"
-        id: 31898046
-        node_id: "MDA6RW50aXR5MQ=="
-        avatar_url: "https://avatars0.githubusercontent.com/u/31898046?v=4"
-        url: "https://api.github.com/users/octokit-fixture-user-a"
-        html_url: "https://github.com/octokit-fixture-user-a"
-        followers_url: "https://api.github.com/users/octokit-fixture-user-a/followers"
-        following_url: "https://api.github.com/users/octokit-fixture-user-a/following{/other_user}"
-        gists_url: "https://api.github.com/users/octokit-fixture-user-a/gists{/gist_id}"
-        starred_url: "https://api.github.com/users/octokit-fixture-user-a/starred{/owner}{/repo}"
-        subscriptions_url: "https://api.github.com/users/octokit-fixture-user-a/subscriptions"
-        organizations_url: "https://api.github.com/users/octokit-fixture-user-a/orgs"
-        repos_url: "https://api.github.com/users/octokit-fixture-user-a/repos"
-        events_url: "https://api.github.com/users/octokit-fixture-user-a/events{/privacy}"
-        received_events_url: "https://api.github.com/users/octokit-fixture-user-a/received_events"
-        type: "User"
-        permissions: {
-          admin: true
-          push: true
-          pull: true
-        }
-      }
-    ]
-    reqheaders: {
-      accept: "application/vnd.github.v3+json"
-      authorization: "token 0000000000000000000000000000000000000001"
-      host: "api.github.com"
-    }
-    headers: {
-      access-control-allow-origin: "*"
-      access-control-expose-headers: "ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type"
-      cache-control: "private, max-age=60, s-maxage=60"
-      connection: "close"
-      content-length: "1127"
-      content-security-policy: "default-src 'none'"
-      content-type: "application/json; charset=utf-8"
-      date: "Tue, 10 Oct 2017 16:00:00 GMT"
-      etag: "\"00000000000000000000000000000000\""
-      referrer-policy: "origin-when-cross-origin, strict-origin-when-cross-origin"
-      status: "200 OK"
-      strict-transport-security: "max-age=31536000; includeSubdomains; preload"
-      x-content-type-options: "nosniff"
-      x-frame-options: "deny"
-      x-github-media-type: "github.v3; format=json"
-      x-github-request-id: "0000:00000:0000000:0000000:00000000"
-      x-oauth-scopes: "admin:gpg_key, admin:org, admin:org_hook, admin:public_key, admin:repo_hook, delete_repo, gist, notifications, repo, user"
-      x-ratelimit-limit: "5000"
-      x-ratelimit-remaining: "4999"
-      x-ratelimit-reset: "1507651200000"
-      x-xss-protection: "1; mode=block"
-    }
-  }
+  {
+    scope: "https://api.github.com:443"
+    method: "get"
+    path: "/repos/octokit-fixture-org/add-and-remove-repository-collaborator/collaborators"
+    status: 200
+    response: [
+      {
+        login: "octokit-fixture-user-a"
+        id: 31898046
+        node_id: "MDA6RW50aXR5MQ=="
+        avatar_url: "https://avatars0.githubusercontent.com/u/31898046?v=4"
+        url: "https://api.github.com/users/octokit-fixture-user-a"
+        html_url: "https://github.com/octokit-fixture-user-a"
+        followers_url: "https://api.github.com/users/octokit-fixture-user-a/followers"
+        following_url: "https://api.github.com/users/octokit-fixture-user-a/following{/other_user}"
+        gists_url: "https://api.github.com/users/octokit-fixture-user-a/gists{/gist_id}"
+        starred_url: "https://api.github.com/users/octokit-fixture-user-a/starred{/owner}{/repo}"
+        subscriptions_url: "https://api.github.com/users/octokit-fixture-user-a/subscriptions"
+        organizations_url: "https://api.github.com/users/octokit-fixture-user-a/orgs"
+        repos_url: "https://api.github.com/users/octokit-fixture-user-a/repos"
+        events_url: "https://api.github.com/users/octokit-fixture-user-a/events{/privacy}"
+        received_events_url: "https://api.github.com/users/octokit-fixture-user-a/received_events"
+        type: "User"
+        permissions: {
+          admin: true
+          push: true
+          pull: true
+        }
+      }
+      {
+        login: "octokit-fixture-user-b"
+        id: 31899067
+        node_id: "MDA6RW50aXR5MQ=="
+        avatar_url: "https://avatars1.githubusercontent.com/u/31899067?v=4"
+        url: "https://api.github.com/users/octokit-fixture-user-b"
+        html_url: "https://github.com/octokit-fixture-user-b"
+        followers_url: "https://api.github.com/users/octokit-fixture-user-b/followers"
+        following_url: "https://api.github.com/users/octokit-fixture-user-b/following{/other_user}"
+        gists_url: "https://api.github.com/users/octokit-fixture-user-b/gists{/gist_id}"
+        starred_url: "https://api.github.com/users/octokit-fixture-user-b/starred{/owner}{/repo}"
+        subscriptions_url: "https://api.github.com/users/octokit-fixture-user-b/subscriptions"
+        organizations_url: "https://api.github.com/users/octokit-fixture-user-b/orgs"
+        repos_url: "https://api.github.com/users/octokit-fixture-user-b/repos"
+        events_url: "https://api.github.com/users/octokit-fixture-user-b/events{/privacy}"
+        received_events_url: "https://api.github.com/users/octokit-fixture-user-b/received_events"
+        type: "User"
+        permissions: {
+          pull: true
+        }
+      }
+    ]
+    reqheaders: {
+      accept: "application/vnd.github.v3+json"
+      authorization: "token 0000000000000000000000000000000000000001"
+      host: "api.github.com"
+    }
+    headers: {
+      access-control-allow-origin: "*"
+      access-control-expose-headers: "ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type"
+      cache-control: "private, max-age=60, s-maxage=60"
+      connection: "close"
+      content-length: "2255"
+      content-security-policy: "default-src 'none'"
+      content-type: "application/json; charset=utf-8"
+      date: "Tue, 10 Oct 2017 16:00:00 GMT"
+      etag: "\"00000000000000000000000000000000\""
+      referrer-policy: "origin-when-cross-origin, strict-origin-when-cross-origin"
+      status: "200 OK"
+      strict-transport-security: "max-age=31536000; includeSubdomains; preload"
+      x-content-type-options: "nosniff"
+      x-frame-options: "deny"
+      x-github-media-type: "github.v3; format=json"
+      x-github-request-id: "0000:00000:0000000:0000000:00000000"
+      x-oauth-scopes: "admin:gpg_key, admin:org, admin:org_hook, admin:public_key, admin:repo_hook, delete_repo, gist, notifications, repo, user"
+      x-ratelimit-limit: "5000"
+      x-ratelimit-remaining: "4999"
+      x-ratelimit-reset: "1507651200000"
+      x-xss-protection: "1; mode=block"
+    }
+  }
 ]
```
@gr2m
Copy link
Contributor

gr2m commented Feb 3, 2020

false positive

@gr2m gr2m closed this Feb 3, 2020
@gr2m gr2m deleted the cron/fixtures-changes/2020-02-03 branch February 3, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants