Skip to content
This repository has been archived by the owner on Jun 20, 2022. It is now read-only.

Please put a tag that refer either commits that is after #64. #147

Closed
lufia opened this issue Mar 25, 2019 · 0 comments
Closed

Please put a tag that refer either commits that is after #64. #147

lufia opened this issue Mar 25, 2019 · 0 comments

Comments

@lufia
Copy link

lufia commented Mar 25, 2019

In Go Modules (GO111MODULE=on), to build octokit become an error.

For example, main.go that is very small Go code below:

package main

import (
    _ "github.com/octokit/go-octokit/octokit"
)

func main() {
}

Then, to build this:

$ GO111MODULE=on go build
go: finding github.com/lostisland/go-sawyer/mediaheader latest
go: finding github.com/lostisland/go-sawyer latest
build lufia.org/test: cannot load github.com/lostisland/go-sawyer/mediaheader: cannot find module providing package github.com/lostisland/go-sawyer/mediaheader

This reason is, because Go Module uses latest tag that is v0.4.0, this is very old broken commit.

lufia added a commit to mackerelio/golib that referenced this issue Mar 25, 2019
go-octokit don't support Go Modules, and it is broken now.
I've filed an issue at octokit/go-octokit/issues/147.

but, sadly, we should avoid this, so I updated to specify a version.

go get -u github.com/octokit/go-octokit@master
@lufia lufia closed this as completed Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant